DonalEvans commented on code in PR #7569:
URL: https://github.com/apache/geode/pull/7569#discussion_r847839798
##########
geode-core/src/main/java/org/apache/geode/internal/cache/versions/DiskVersionTag.java:
##########
@@ -44,7 +44,7 @@ public void setMemberID(DiskStoreID memberID) {
@Override
public void replaceNullIDs(VersionSource memberID) {
if (getMemberID() == null) {
- throw new AssertionError("Member id should not be null for persistent
version tags");
+ throw new IllegalStateException("Member id should not be null for
persistent version tags");
Review Comment:
Given that throwing a checked exception from `replaceNullIDs()` resulted in
pretty big cascading changes, I modified the approach to instead be to not
throw an exception at all if the memberID is null, but instead check if it's
still null after calling `replaceNullIDs()` and returning false from
`processChunk()` if it is.
Given that we've never seen the old `AssertionError` show up anywhere else,
and that it wasn't being handled anywhere, removing the exception throwing
behaviour entirely should be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
