pivotal-jbarrett commented on code in PR #7608:
URL: https://github.com/apache/geode/pull/7608#discussion_r857955468


##########
geode-cq/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/DurableClientTestBase.java:
##########
@@ -216,33 +208,35 @@ void verifyDurableClientPresence(int 
durableClientTimeout, String durableClientI
     });
   }
 
+  void waitUntilHARegionQueueSizeIsZero(VM serverVM) {
+    serverVM.invoke(() -> await().atMost(60, SECONDS)
+        .until(() -> getClientProxy().getHARegionQueue().size() == 0));
+  }
+
   public void closeDurableClient() {
     durableClientVM.invoke((SerializableRunnableIF) 
CacheServerTestUtil::closeCache);
   }
 
   public void disconnectDurableClient(boolean keepAlive) {
-    printClientProxyState("Before");
+    // printClientProxyState("Before");
     durableClientVM.invoke("close durable client cache",
         () -> CacheServerTestUtil.closeCache(keepAlive));
-    await()
-        .until(CacheServerTestUtil::getCache, nullValue());
-    printClientProxyState("after");
+    await().until(CacheServerTestUtil::getCache, nullValue());
+    // printClientProxyState("after");

Review Comment:
   Step on them. Tests should not log. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to