pivotal-jbarrett commented on code in PR #7608:
URL: https://github.com/apache/geode/pull/7608#discussion_r857959691
##########
geode-core/src/distributedTest/java/org/apache/geode/cache/client/ClientServerRegisterInterestsDUnitTest.java:
##########
@@ -224,27 +205,27 @@ public void testClientRegisterInterests() {
Region<String, String> example = clientCache.getRegion(SEPARATOR +
"Example");
assertNotNull("'Example' Region in Client Cache was not found!",
example);
- assertEquals(1, example.size());
+ assertThat(example.size()).isEqualTo(1);
assertTrue(example.containsKey("1"));
- assertEquals("ONE", example.get("1"));
+ assertThat(example.get("1")).isEqualTo("ONE");
Review Comment:
How so?
The prescribed method in a single like declares the map should only contain
a single entry with the specified key and value. The error message here would
be that either the map had other entries, and here are the entries, or it does
not contain the 1 entry we asserted.
As written, if the entry was missing at 210 the error would be "null" !=
"ONE". If there were more entries, 208 would error "8 != 1". Neither of these
will mention anything about map size, entries, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
