jdaugherty commented on code in PR #15067:
URL: https://github.com/apache/grails-core/pull/15067#discussion_r2350495272
##########
grails-geb/src/testFixtures/groovy/grails/plugin/geb/WebDriverContainerHolder.groovy:
##########
@@ -162,18 +162,10 @@ class WebDriverContainerHolder {
}
}
- // If `GebConfig` instantiates a `RemoteWebDriver` without using it's
`remoteAddress` constructor,
- // the `RemoteWebDriver` will be instantiated using the
`webdriver.remote.server` system property.
- String existingPropertyValue =
System.getProperty('webdriver.remote.server')
+ // If a custom `GebConfig` instantiates a `RemoteWebDriver` without
using it's `remoteAddress` constructor,
+ // the `RemoteWebDriver` will be instantiated using the
`webdriver.remote.server` system property,
+ // so we need to set that value.
System.setProperty('webdriver.remote.server',
currentContainer.seleniumAddress.toString())
- gebConfig.driver // This will implicitly call `createDriver()`
Review Comment:
Wasn't the intent of this code to force the test container always?
##########
build.gradle:
##########
@@ -70,6 +70,7 @@ allprojects {
url = 'https://repository.apache.org/content/groups/staging'
content {
includeModuleByRegex('org[.]apache[.]grails[.]gradle',
'grails-publish')
+ includeModuleByRegex('org[.]apache[.]groovy[.]geb', 'geb-.*')
Review Comment:
I thought you could only have one of these includes? does this effectively
or the expressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
