JonasPammer commented on code in PR #15067:
URL: https://github.com/apache/grails-core/pull/15067#discussion_r2351526786
##########
grails-geb/src/testFixtures/groovy/grails/plugin/geb/WebDriverContainerHolder.groovy:
##########
@@ -162,18 +162,10 @@ class WebDriverContainerHolder {
}
}
- // If `GebConfig` instantiates a `RemoteWebDriver` without using it's
`remoteAddress` constructor,
- // the `RemoteWebDriver` will be instantiated using the
`webdriver.remote.server` system property.
- String existingPropertyValue =
System.getProperty('webdriver.remote.server')
+ // If a custom `GebConfig` instantiates a `RemoteWebDriver` without
using it's `remoteAddress` constructor,
+ // the `RemoteWebDriver` will be instantiated using the
`webdriver.remote.server` system property,
+ // so we need to set that value.
System.setProperty('webdriver.remote.server',
currentContainer.seleniumAddress.toString())
- gebConfig.driver // This will implicitly call `createDriver()`
Review Comment:
As the cautious/unecessary restore was removed, it will just happen at any
the next call to
[.driver](https://github.com/apache/groovy-geb/blob/4266eeeea6f59e4718339b93283327bf176563b9/module/geb-core/src/main/groovy/geb/Browser.groovy#L172)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
