jdaugherty commented on code in PR #15398:
URL: https://github.com/apache/grails-core/pull/15398#discussion_r2829780859
##########
grails-gsp/core/src/main/groovy/org/grails/gsp/compiler/GroovyPageParser.java:
##########
@@ -463,14 +463,11 @@ public void writeLineNumbers(File filename) throws
IOException {
}
private void declare(boolean gsp) {
- if (finalPass) {
- return;
- }
-
- out.println();
- write(scan.getToken().trim(), gsp);
Review Comment:
The app you linked is a Grails 6 app though. Is there a branch where you
tested this with Grails 6?
##########
grails-gsp/core/src/main/groovy/org/grails/gsp/compiler/GroovyPageParser.java:
##########
@@ -463,14 +463,11 @@ public void writeLineNumbers(File filename) throws
IOException {
}
private void declare(boolean gsp) {
- if (finalPass) {
- return;
- }
-
- out.println();
- write(scan.getToken().trim(), gsp);
Review Comment:
The app you linked is a Grails 7 app though. Is there a branch where you
tested this with Grails 6?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
