jamesfredley commented on code in PR #15398:
URL: https://github.com/apache/grails-core/pull/15398#discussion_r2829842845
##########
grails-gsp/core/src/main/groovy/org/grails/gsp/compiler/GroovyPageParser.java:
##########
@@ -463,14 +463,11 @@ public void writeLineNumbers(File filename) throws
IOException {
}
private void declare(boolean gsp) {
- if (finalPass) {
- return;
- }
-
- out.println();
- write(scan.getToken().trim(), gsp);
Review Comment:
I did not, but that code has been present since Grails 1.1, so the outcome
should be the same. Users in general know `<%! int counter = 0; %>` is a bad
idea, but if they try it, it compiles but then errors during runtime. This
PR is just trying to alert them during the build instead of at runtime. The
outcome is the same, an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
