jdaugherty commented on PR #15341: URL: https://github.com/apache/grails-core/pull/15341#issuecomment-3941585687
Hi @sanjana2505006 for now this plugin seems like an ok approach, but your implementation doesn't meet our needs nor our standards. One of the major build rules we have after our experience in refactoring the build is to use composition. This means we never define project specific configuration in the root build config. The proper way to configure this plugin is to have a convention plugin under build-logic, and apply that plugin to every gradle project in our build. However, in the case of this plugin, such support has already been added via a settings plugin. So we should just adopt the settings plugin instead of the project based configuration. Remember: the grails-core build is a composite build. There are 4 gradle projects in the repo: build-logic, grails-gradle, grails-core (the root repo path), and grails-forge. Every one of these projects has a settings.gradle. We need to apply this plugin to each of these then. We also need to configure the plugin for each of these project - and that logic should be shared in a single gradle file. Can you please update your PR to make use of the settings plugin, and to centralize the configuration? Let's start there and then we can take a further review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
