jdaugherty commented on PR #15409: URL: https://github.com/apache/grails-core/pull/15409#issuecomment-3980455034
This change is incomplete since the plugin configuration will be loaded potentially when the plugin is disabled. We may be able to post process already loaded configuration and remove them, but I'm not sure without further research. Here's the loading order in Spring: • SpringApplication.run(...) • Prepare SpringApplicationRunListeners • Prepare Environment Create/attach ConfigurableEnvironment Invoke all EnvironmentPostProcessors • Create ApplicationContext • Prepare context • Refresh context (bean creation begins) The problem is the plugin manager has different discovery mechanisms (but very similar). Worst, one of those mechanisms appears to require the application context, which won't exist when we need to load configuration. I *think* the need for the application context (or rather the parent application context) isn't actually used though. I'm doing further research on this to see how best to unify the plugin manager mechanisms so we can share the logic in both places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
