jamesfredley commented on PR #15474: URL: https://github.com/apache/grails-core/pull/15474#issuecomment-3987438419
Added unit tests in `DatastoreServiceMethodInvokingFactoryBeanSpec` - 7 Spock tests covering all `resolveEffectiveDatastore()` code paths, including both null guard branches. Regarding functional tests in `grails-test-examples`: these aren't feasible for this change. The null guard paths throw `ConfigurationException` during bean initialization (before the app is fully started), so there's no way to exercise them from a running functional test. The unit tests cover this thoroughly by mocking `MultipleConnectionSourceCapableDatastore` and verifying both the happy path and the error paths directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
