rahulshishodia commented on code in PR #15382:
URL: https://github.com/apache/grails-core/pull/15382#discussion_r2927056272


##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsExtension.groovy:
##########
@@ -106,6 +107,18 @@ class GrailsExtension {
         this.indy.set(enabled)
     }
 
+    /**
+     * Preserve method parameter names in .class files (enables better IDE 
code completion for method parameters,
+     * reflection-based tools, bean introspection, etc.).
+     * Corresponds to groovyc `-parameters`.
+     * Default: true (See #13028)
+     */
+    final Property<Boolean> preserveParameterNames
+
+    void setPreserveParameterNames(boolean enabled) {

Review Comment:
   @jdaugherty — You were right that the setter is unnecessary. The root cause 
was how the extension was being registered. The extension was registered using 
`extensions.add('grails', new GrailsExtension(project))`, passing a ready made 
extension skipping gradles handling, I have switched to 
`extensions.create('grails', GrailsExtension, project)` this would let 
`ObjectFactory` take care of initialization. I have removed the setter as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to