jdaugherty commented on code in PR #15382:
URL: https://github.com/apache/grails-core/pull/15382#discussion_r3035674963
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy:
##########
@@ -228,10 +228,17 @@ class GrailsGradlePlugin implements Plugin<Project> {
// Configure indy and log status after evaluation so user's grails { }
block has been applied
GrailsExtension grailsExtension =
project.extensions.findByType(GrailsExtension)
project.afterEvaluate {
- boolean indyEnabled = grailsExtension?.indy?.getOrElse(false) ?:
false
+ boolean indyEnabled = grailsExtension.indy?.getOrElse(false) ?:
false
+ boolean preserveParameterNames =
grailsExtension.preserveParameterNames?.getOrElse(true)
+
project.tasks.withType(GroovyCompile).configureEach {
GroovyCompile c ->
c.groovyOptions.optimizationOptions.indy = indyEnabled
+
+ if (preserveParameterNames) {
Review Comment:
I still don't think this is right. There should be 3 cases:
null => do not set anything
false => set parameters to false
true => set parameters to true
Default should be "true"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
