jdaugherty commented on PR #15409: URL: https://github.com/apache/grails-core/pull/15409#issuecomment-4104820915
@matrei I think I've responded to all of your feedback. Concerning this comment: `@ConditionalOnProperty was introduced in Spring Boot 1.1` While it was introduced in Spring Boot 1.1 & did not work in priors Grails Versions, Grails 7 was the first release where we started using `@Configuration` & `@ConditionalOnProperty`. For example: `UrlMappingsAutoConfiguration` uses `@ConditionalOnProperty`. In previous Grails versions, one could use the plugin architecture to replace beans, in Grails 7 this isn't possible due the bug fixed by this PR. Given that we have adopted a solution that our end users can't override with Grails Plugins, I view this as a critical issue and it should be fixed in 7.1.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
