jamesfredley commented on code in PR #15541:
URL: https://github.com/apache/grails-core/pull/15541#discussion_r3030281552
##########
grails-controllers/build.gradle:
##########
@@ -43,6 +43,8 @@ dependencies {
api 'org.apache.groovy:groovy'
api 'org.springframework.boot:spring-boot-autoconfigure'
+ api 'org.springframework.boot:spring-boot-webmvc'
Review Comment:
Added a comment explaining why this dependency is here. In Spring Framework
7, `spring-webmvc` no longer transitively exports `spring-web`, so
`grails-controllers` needs it explicitly since `grails-web-common` no longer
provides it transitively.
##########
grails-data-hibernate5/core/build.gradle:
##########
@@ -45,6 +45,8 @@ dependencies {
api 'org.apache.groovy:groovy'
api project(':grails-datamapping-core')
api 'org.springframework:spring-orm'
+ api 'org.springframework:spring-web'
Review Comment:
This was added because the vendored Spring ORM files needed `spring-web`
types. However, we've since moved those vendored files to a separate
`grails-data-hibernate5/spring-orm` subproject per your suggestion, so this
dependency has been removed from `core/build.gradle`.
##########
grails-data-hibernate5/core/build.gradle:
##########
@@ -91,3 +93,8 @@ apply {
from
rootProject.layout.projectDirectory.file('gradle/grails-data-tck-config.gradle')
from rootProject.layout.projectDirectory.file('gradle/docs-config.gradle')
}
+
+tasks.named('checkstyleMain', Checkstyle) {
Review Comment:
Removed the checkstyle exclusion. The vendored Spring files have been moved
to the separate `grails-data-hibernate5/spring-orm` subproject, so they no
longer need to be excluded from the core module's style checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
