jdaugherty commented on code in PR #15541:
URL: https://github.com/apache/grails-core/pull/15541#discussion_r3030338745
##########
grails-bom/build.gradle:
##########
@@ -224,6 +224,15 @@ ext {
for (Map.Entry<String, String> property :
pomProperties.entrySet()) {
propertiesNode.appendNode(property.key, property.value)
}
+
+ // Override Spring Boot's groovy.version property with Grails'
version
+ // Spring Boot 4.0.5 defaults to Groovy 5.0.4, but Grails 8.0.x
uses Groovy 4.0.31
+ def groovyVersionNode = propertiesNode.'groovy.version'
Review Comment:
There are 2 separate concerns here:
1. for selecting the right groovy version, the bom already supports
mismatching spring boot. Are you saying gradle is not honoring the constraint
override?
2. for enforcing downstream projects, that is done by a different mechanism.
For our projects, we should use enforcePlatform() if transitive dependencies
are causing this problem (i'd rather we avoid enforced though and fix those
transitive dependencies, but I'm pretty sure enforced will just cause an error
in that case). For generated grails projects we should consider generating a
gradle.properties with `groovy.version` set to prevent mismatches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
