jdaugherty commented on code in PR #15541:
URL: https://github.com/apache/grails-core/pull/15541#discussion_r3032516547
##########
grails-web-boot/src/test/groovy/grails/boot/EmbeddedContainerWithGrailsSpec.groovy:
##########
@@ -18,63 +18,33 @@
*/
package grails.boot
-import org.springframework.core.env.ConfigurableEnvironment
-import org.springframework.web.context.support.StandardServletEnvironment
-
import grails.artefact.Artefact
import grails.boot.config.GrailsAutoConfiguration
import grails.web.Controller
import org.springframework.boot.autoconfigure.EnableAutoConfiguration
-import
org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory
-import
org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext
-import
org.springframework.boot.web.servlet.server.ConfigurableServletWebServerFactory
-import org.springframework.context.annotation.Bean
+import spock.lang.Ignore
import spock.lang.Specification
-import org.apache.grails.core.plugins.DefaultPluginDiscovery
-import org.apache.grails.core.plugins.PluginDiscovery
-
/**
- * Created by graemerocher on 28/05/14.
+ * Tests loading Grails in an embedded server configuration.
+ *
+ * TODO: Rework for Spring Boot 4.0 modularized embedded server APIs.
+ * Embedded server classes moved to spring-boot-web-server and
spring-boot-tomcat modules
+ * and require updated test patterns.
*/
+@Ignore("Spring Boot 4.0: Embedded server test infrastructure needs
significant rework due to modularization. " +
Review Comment:
I think my comment still stands. This needs fixed to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
