jdaugherty commented on code in PR #15541:
URL: https://github.com/apache/grails-core/pull/15541#discussion_r3035651578
##########
grails-web-boot/src/test/groovy/grails/boot/GrailsSpringApplicationSpec.groovy:
##########
@@ -19,42 +19,29 @@
package grails.boot
import grails.boot.config.GrailsAutoConfiguration
-import org.springframework.boot.SpringApplication
import org.springframework.boot.autoconfigure.EnableAutoConfiguration
-import
org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory
-import
org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext
-import
org.springframework.boot.web.servlet.server.ConfigurableServletWebServerFactory
-import org.springframework.context.annotation.Bean
+import spock.lang.Ignore
import spock.lang.Specification
/**
- * Created by graemerocher on 28/05/14.
+ * Tests running Grails via SpringApplication with an embedded server.
+ *
+ * TODO: Rework for Spring Boot 4.0 modularized embedded server APIs.
+ * Embedded server classes moved to spring-boot-web-server and
spring-boot-tomcat modules
+ * and require updated test patterns.
*/
-class GrailsSpringApplicationSpec extends Specification{
-
- AnnotationConfigServletWebServerApplicationContext context
-
- void cleanup() {
- context.close()
- }
+@Ignore("Spring Boot 4.0: Embedded server test infrastructure needs
significant rework due to modularization. " +
Review Comment:
This is incorrect. See https://github.com/apache/grails-core/pull/15554 for
the proper fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
