sanjana2505006 commented on code in PR #15555:
URL: https://github.com/apache/grails-core/pull/15555#discussion_r3068395510
##########
build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/GrailsCodeStylePlugin.groovy:
##########
@@ -108,8 +112,10 @@ class GrailsCodeStylePlugin implements Plugin<Project> {
}
private static void doNotApplyStylingToTests(Project project) {
- project.tasks.named('checkstyleTest') {
- it.enabled = false // Do not check test sources at this time
+ if (project.tasks.names.contains('checkstyleTest')) {
Review Comment:
I originally added this to focus the initial rollout on production source
code and avoid overwhelming the PR with style violations from the existing test
suite. However, I agree that tests should ideally follow the same standards.
Would you prefer that I remove this block and enable styling for tests as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
