jamesfredley commented on code in PR #15365:
URL: https://github.com/apache/grails-core/pull/15365#discussion_r3089274706
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/commands/ApplicationContextCommandTask.groovy:
##########
@@ -20,7 +20,13 @@ package org.grails.gradle.plugin.commands
import groovy.transform.CompileStatic
+import org.gradle.api.model.ObjectFactory
+import org.gradle.api.provider.ProviderFactory
import org.gradle.api.tasks.JavaExec
+import org.gradle.jvm.toolchain.JavaToolchainService
+import org.gradle.process.internal.ExecActionFactory
+
Review Comment:
Fixed. The unused imports (ObjectFactory, ProviderFactory,
JavaToolchainService, ExecActionFactory) were already removed in a subsequent
commit - no action needed.
##########
grails-forge/gradle/test-config.gradle:
##########
@@ -17,6 +17,13 @@
* under the License.
*/
+// Add JUnit Platform launcher dependency required by Gradle 9 for running
tests
+// Also add ByteBuddy for Spock mocking on Java 17+ (CGLIB doesn't support
Java 17 class files)
+dependencies {
+ testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
Review Comment:
Fixed. Added explicit version \1.12.2\ to \junit-platform-launcher\.
##########
.sdkmanrc:
##########
@@ -2,5 +2,5 @@
java=17.0.18-librca
# Keep gradle version synced with gradle.properties (gradleToolingApiVersion),
all gradle-wrapper.properties files,
Review Comment:
Fixed. Updated the comment to reference the gradle-bootstrap project for
propagating the version to all wrapper files.
##########
grails-gradle/bom/build.gradle:
##########
@@ -43,8 +43,9 @@ dependencies {
exclude group: 'com.fasterxml.jackson'
}
- // Because gradle uses groovy 3, we must use groovy 3 compatible versions
for the grails-gradle-bom
- api platform("org.codehaus.groovy:groovy-bom:${GroovySystem.version}")
+ // Use Gradle's embedded Groovy version for the grails-gradle-bom
+ // Groovy 4+ uses org.apache.groovy coordinates
+ api platform("org.apache.groovy:groovy-bom:${GroovySystem.version}")
Review Comment:
Fixed. Extracted the Groovy version into \gradleBomDependencyVersions\ as
\gradle-groovy.version: 4.0.31\ and added a \gradle-groovy-bom\ entry to
\gradleBomPlatformDependencies\. The bom/build.gradle now references
\gradleBomPlatformDependencies['gradle-groovy-bom']\ instead of
\GroovySystem.version\.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
