jamesfredley commented on PR #15365:
URL: https://github.com/apache/grails-core/pull/15365#issuecomment-4255389633
Addressed all review comments and the three big issues from the review body:
**Inline comments (all resolved):**
- Unused imports: already cleaned up in a prior commit
- junit-platform-launcher: added explicit version 1.12.2
- .sdkmanrc: updated comment to reference gradle-bootstrap project
- Groovy version: extracted to gradleBomDependencyVersions map, bom
references gradleBomPlatformDependencies['gradle-groovy-bom']
- GrailsProfileGradlePlugin inputs: restored the 4
inputs.dir().optional().skipWhenEmpty() declarations
- issue-11767 compileJava: disabled compileJava instead of the JSON metadata
merge hack
- CycloneDX: upgraded from 2.4.1 to 3.0.0, rewrote SbomPlugin for
CyclonedxDirectTask API
- SbomPlugin providers: converted isReproducibleBuild and buildDate to lazy
Provider types
**Big Issue 1 - Gradle 9 blockers in grails-gradle plugins:**
- GrailsExtension: replaced removed ConfigureUtil.configure() with
ClosureBackedAction
- GrailsPluginGradlePlugin: migrated project.task(type: Copy, ...) to
tasks.register(...)
- GrailsGradlePlugin: migrated project.tasks.create('buildProperties') to
tasks.register(...)
**Big Issue 2 - Configuration cache:**
- Explicitly set org.gradle.configuration-cache=false in gradle.properties
with reference to #15497
**Big Issue 3 - ExtractDependenciesTask:**
- Removed all project access from execution time (@TaskAction and
populatePlatformDependencies)
- Added captureProjectServices() method to capture DependencyHandler and
ConfigurationContainer at configuration time
- Moved the java-platform plugin check from doFirst to configuration time in
the task registration site
- Note: still creates detached configurations at execution time
(incompatible with configuration cache), but this is acceptable since
configuration cache is explicitly disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
