jamesfredley commented on code in PR #25:
URL:
https://github.com/apache/grails-gradle-publish/pull/25#discussion_r3126557217
##########
plugin/src/test/groovy/org/apache/grails/gradle/publish/GrailsPublishGradlePluginTest.groovy:
##########
@@ -107,10 +107,8 @@ class GrailsPublishGradlePluginTest extends Specification {
'closeStagingRepositories',
'compileJava',
'compileTestJava',
- 'components',
'dependencies',
'dependencyInsight',
Review Comment:
Legitimate concern, but out of scope for this PR. The full-task-list
assertion pattern predates this change; my diff only removes the three Software
Model tasks (`components`, `dependentComponents`, `model`) that Gradle 9
removed, to keep the existing test passing.
Switching to a plugin-scoped assertion changes what the test verifies (it
currently doubles as a tripwire for unexpected task additions), so it deserves
its own PR where the trade-off can be discussed on its own merits rather than
bundled with a Gradle upgrade. Happy to file a follow-up issue if you want it
tracked.
Resolving.
##########
plugin/src/test/groovy/org/apache/grails/gradle/publish/GrailsPublishGradlePluginTest.groovy:
##########
@@ -197,10 +194,8 @@ class GrailsPublishGradlePluginTest extends Specification {
'clean',
'compileJava',
'compileTestJava',
- 'components',
'dependencies',
'dependencyInsight',
Review Comment:
Same reasoning as [the other
thread](https://github.com/apache/grails-gradle-publish/pull/25#discussion_r3126496866)
- valid point, but the test-strategy refactor is out of scope for a Gradle
upgrade PR. Keeping the minimal diff that lets the existing assertion style
continue to pass on Gradle 9. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
