sbglasius commented on code in PR #25:
URL:
https://github.com/apache/grails-gradle-publish/pull/25#discussion_r3126516446
##########
gradle/test-config.gradle:
##########
@@ -41,11 +41,11 @@ import org.gradle.api.plugins.jvm.JvmTestSuite
testing {
suites {
test {
- useSpock('2.3-groovy-3.0')
+ useSpock('2.3-groovy-4.0')
Review Comment:
I suggest moving to spock 2.4-groovy-4.0
##########
plugin/build.gradle:
##########
@@ -27,10 +27,10 @@ group = 'org.apache.grails.gradle'
dependencies {
// compile grails-gradle-plugin with the Groovy version provided by Gradle
- // to ensure build compatibility with Gradle, currently Groovy 3.0.x
+ // to ensure build compatibility with Gradle, currently Groovy 4.0.x
// see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
- api platform("org.codehaus.groovy:groovy-bom:${GroovySystem.version}")
- compileOnly 'org.codehaus.groovy:groovy'
+ api platform("org.apache.groovy:groovy-bom:${GroovySystem.version}")
Review Comment:
well spotted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
