Copilot commented on code in PR #15602:
URL: https://github.com/apache/grails-core/pull/15602#discussion_r3141078299
##########
.github/workflows/gradle.yml:
##########
@@ -454,6 +448,49 @@ jobs:
with:
name: grails-forge-artifacts.txt
path: grails-forge/build/grails-forge-artifacts.txt
+ verifyWrapper:
+ name: "Verify grails-wrapper"
+ # The wrapper smoke test downloads org.apache.grails:grails-cli from
Apache Nexus.
+ # That artifact is published by publishForge (in the grails-forge
sub-project), so
+ # verification must run after BOTH publish (grails-core, which publishes
the wrapper
+ # itself) AND publishForge (which publishes grails-cli). Previously the
verify step
+ # lived inside publish and would 404 the very first time projectVersion
was bumped,
+ # because publishForge had not yet pushed grails-cli for the new SNAPSHOT
version.
+ if: github.repository_owner == 'apache' && (github.event_name == 'push' ||
github.event_name == 'workflow_dispatch')
+ needs: [ publish, publishForge ]
+ runs-on: ubuntu-24.04
+ steps:
+ - name: "Output Agent IP" # in the event RAO blocks this agent, this can
be used to debug it
Review Comment:
The "Output Agent IP" step runs `curl -s https://api.ipify.org` and will
fail the entire `verifyWrapper` job if the external service/DNS/network is
temporarily unavailable. Since this is debug-only output, make the step
non-blocking (e.g., `continue-on-error: true` or `curl ... || true`) so wrapper
verification isn’t made flaky by an unrelated outbound dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
