jdaugherty commented on code in PR #15602:
URL: https://github.com/apache/grails-core/pull/15602#discussion_r3141960472
##########
.github/workflows/gradle.yml:
##########
@@ -454,6 +448,49 @@ jobs:
with:
name: grails-forge-artifacts.txt
path: grails-forge/build/grails-forge-artifacts.txt
+ verifyWrapper:
+ name: "Verify grails-wrapper"
+ # The wrapper smoke test downloads org.apache.grails:grails-cli from
Apache Nexus.
Review Comment:
the original point of this verification wasn't to do a smoke test on the
download, but to verify the wrapper actually works.
##########
.github/workflows/gradle.yml:
##########
@@ -454,6 +448,49 @@ jobs:
with:
name: grails-forge-artifacts.txt
path: grails-forge/build/grails-forge-artifacts.txt
+ verifyWrapper:
+ name: "Verify grails-wrapper"
+ # The wrapper smoke test downloads org.apache.grails:grails-cli from
Apache Nexus.
+ # That artifact is published by publishForge (in the grails-forge
sub-project), so
+ # verification must run after BOTH publish (grails-core, which publishes
the wrapper
+ # itself) AND publishForge (which publishes grails-cli). Previously the
verify step
+ # lived inside publish and would 404 the very first time projectVersion
was bumped,
+ # because publishForge had not yet pushed grails-cli for the new SNAPSHOT
version.
+ if: github.repository_owner == 'apache' && (github.event_name == 'push' ||
github.event_name == 'workflow_dispatch')
+ needs: [ publish, publishForge ]
+ runs-on: ubuntu-24.04
+ steps:
+ - name: "Output Agent IP" # in the event RAO blocks this agent, this can
be used to debug it
+ run: curl -s https://api.ipify.org
+ - name: "📥 Checkout repository"
+ uses: actions/checkout@v6
+ - name: "☕️ Setup JDK"
+ uses: actions/setup-java@v4
+ with:
+ distribution: liberica
+ java-version: 17
+ - name: "📥 Download Wrapper Distribution Zip"
+ uses: actions/[email protected]
+ with:
+ name: apache-grails-wrapper-distribution-zip
+ path: build
+ - name: "✅ Verify grails-wrapper"
+ env:
+ GRAILS_WRAPPER_ALLOWED_TYPES: 'SNAPSHOT'
+ run: |
+ # Pin the wrapper to this branch's snapshot so it doesn't resolve the
+ # globally latest SNAPSHOT in the Apache repo, which may be compiled
+ # for a newer Java runtime than this job's JDK.
+ export PREFERRED_GRAILS_VERSION=$(grep '^projectVersion='
gradle.properties | cut -d'=' -f2)
+ cd build
+ unzip wrapper.zip -d tmp
+ mv tmp/apache-grails-wrapper-* tmp/wrapper
+ ./tmp/wrapper/grailsw --version
+ - name: "📤 Upload Wrapper Zip to Workflow Summary Page"
Review Comment:
Why are you re-uploading the zip file that was downloaded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
