jamesfredley commented on code in PR #15602:
URL: https://github.com/apache/grails-core/pull/15602#discussion_r3142054061


##########
.github/workflows/gradle.yml:
##########
@@ -454,6 +448,49 @@ jobs:
         with:
           name: grails-forge-artifacts.txt
           path: grails-forge/build/grails-forge-artifacts.txt
+  verifyWrapper:
+    name: "Verify grails-wrapper"
+    # The wrapper smoke test downloads org.apache.grails:grails-cli from 
Apache Nexus.

Review Comment:
   Comments updated



##########
.github/workflows/gradle.yml:
##########
@@ -454,6 +448,49 @@ jobs:
         with:
           name: grails-forge-artifacts.txt
           path: grails-forge/build/grails-forge-artifacts.txt
+  verifyWrapper:
+    name: "Verify grails-wrapper"
+    # The wrapper smoke test downloads org.apache.grails:grails-cli from 
Apache Nexus.
+    # That artifact is published by publishForge (in the grails-forge 
sub-project), so
+    # verification must run after BOTH publish (grails-core, which publishes 
the wrapper
+    # itself) AND publishForge (which publishes grails-cli). Previously the 
verify step
+    # lived inside publish and would 404 the very first time projectVersion 
was bumped,

Review Comment:
   Comments updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to