jdaugherty commented on code in PR #15602:
URL: https://github.com/apache/grails-core/pull/15602#discussion_r3142056876
##########
.github/workflows/gradle.yml:
##########
@@ -392,27 +392,21 @@ jobs:
name: grails-core-artifacts.txt
path: build/grails-core-artifacts.txt
- name: "🔨 Create Grails Wrapper Distribution Zip"
- run: >
- ./gradlew :grails-wrapper:distZip
- - name: "✅ Verify grails-wrapper"
- if: success()
- env:
- GRAILS_WRAPPER_ALLOWED_TYPES: 'SNAPSHOT'
run: |
- # Pin the wrapper to this branch's snapshot so it doesn't resolve the
- # globally latest SNAPSHOT in the Apache repo, which may be compiled
- # for a newer Java runtime than this job's JDK.
- export PREFERRED_GRAILS_VERSION=$(grep '^projectVersion='
gradle.properties | cut -d'=' -f2)
+ ./gradlew :grails-wrapper:distZip
+ mkdir -p build
cp grails-wrapper/build/distributions/apache-grails-wrapper-*.zip
build/wrapper.zip
- cd build
- unzip wrapper -d tmp
- mv tmp/apache-grails-wrapper-* tmp/wrapper
- ./tmp/wrapper/grailsw --version
- - name: "📤 Upload Wrapper Zip to Workflow Summary Page"
+ - name: "📤 Upload Wrapper Distribution Zip"
+ # Intermediate artifact consumed by the verifyWrapper job after
publishForge has
+ # uploaded grails-cli to Nexus. The user-facing
apache-grails-wrapper-SNAPSHOT-bin
+ # artifact is produced by verifyWrapper from the contents of this zip.
The zip is
+ # renamed to a stable filename so the download step in verifyWrapper
does not have
+ # to glob over a version-stamped path.
uses: actions/[email protected]
with:
- name: apache-grails-wrapper-SNAPSHOT-bin
- path: build/tmp/wrapper
+ name: apache-grails-wrapper-distribution-zip
Review Comment:
@jamesfredley the name should stay as "SNAPSHOT" and not distribution - we
don't want people to think these are releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
