jamesfredley commented on PR #15365:
URL: https://github.com/apache/grails-core/pull/15365#issuecomment-4320073079
## CI fixes (commits 735ce324df, 0314d5fd96)
Pushed two follow-up commits resolving the CI failures introduced by the
previous batch.
### Failures and fixes
| Failing job(s) | Root cause | Fix | Commit |
|---|---|---|---|
| `Validate Dependency Versions` | `GroovySystem.version` returns Gradle's
*bundled* Groovy (4.0.29 for Gradle 9.4.1), but grails-gradle plugin code
transitively resolves 4.0.31 via grails-core. The validator flagged every
`org.apache.groovy:*` artifact as `resolved 4.0.31, expected 4.0.29` and
failed. | Revert `gradle-groovy.version` to hard-coded `'4.0.31'`. Added an
inline comment (no specific version numbers - those drift) explaining why
`GroovySystem.version` is not viable here. | `735ce324df` |
| `Build Grails Forge (Java 21, indy=false)`, `(Java 21, indy=true)`, `(Java
25, indy=false)` | After 014355310b dropped `:$groovyVersion` from the
`documentation` entries in `grails-forge/gradle/doc-config.gradle`, the
unversioned `org.apache.groovy:groovy-*` artifacts had no version source. The
`documentation` configuration is registered by the buildsrc.groovydoc plugin
and is independent of `compileClasspath` / `testRuntimeClasspath`, so the
micronaut-platform BOM applied in each forge module's main `dependencies { }`
block does not reach it. groovydoc failed with `Could not find
org.apache.groovy:groovy-templates:.` | Apply
`platform("io.micronaut.platform:micronaut-platform:$micronautVersion")` to the
`documentation` configuration in `doc-config.gradle` so unversioned coordinates
resolve through `groovy-bom`. Same BOM-driven approach we use elsewhere in
forge. | `0314d5fd96` |
| `Build Grails-Core (windows-latest, 25)` | Transient Maven Central 403
while resolving `org.cyclonedx:cyclonedx-core-java:11.0.0`: `Received status
code 403 from server: Forbidden` from both `repo.maven.apache.org/maven2` and
`plugins.gradle.org/m2`. Not a code issue. | None - should clear on retry. The
same job passes on Linux runners and on JDK 21 Windows runs. | n/a |
### Verification
| Check | Result |
|---|---|
| `./gradlew :grails-gradle-plugins:validateDependencyVersions
:grails-gradle-tasks:validateDependencyVersions` | PASS |
| `./gradlew validateDependencyVersions` (whole project, 157 tasks) | PASS |
| `./gradlew :grails-forge-cli:groovydoc :grails-forge-api:groovydoc
:grails-forge-core:groovydoc` | PASS |
### Note on `GroovySystem.version` (re #15365 (comment 3141965549))
@jdaugherty - your original suggestion to derive `gradle-groovy.version`
from `GroovySystem.version` was reasonable in principle but breaks
`validateDependencyVersions` whenever Gradle's bundled Groovy lags
grails-core's chosen Groovy. They're independently versioned and currently
differ by one patch. I went back to the literal so the BOM matches what we
actually publish/resolve. Discussion in
https://github.com/apache/grails-core/pull/15365#discussion_r3141965549 - happy
to revisit if you'd prefer a different formulation.
Assisted-by: claude-code:claude-opus-4-7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
