jamesfredley commented on code in PR #15365:
URL: https://github.com/apache/grails-core/pull/15365#discussion_r3142273395
##########
grails-forge/grails-forge-core/build.gradle:
##########
@@ -41,13 +41,15 @@ sourceSets {
}
dependencies {
- annotationProcessor
platform("io.micronaut:micronaut-bom:$micronautVersion")
- implementation platform("io.micronaut:micronaut-bom:$micronautVersion")
+ annotationProcessor
platform("io.micronaut.platform:micronaut-platform:$micronautVersion")
+ implementation
platform("io.micronaut.platform:micronaut-platform:$micronautVersion")
annotationProcessor 'io.micronaut:micronaut-inject-java'
- testAnnotationProcessor
platform("io.micronaut:micronaut-bom:$micronautVersion")
+ testAnnotationProcessor
platform("io.micronaut.platform:micronaut-platform:$micronautVersion")
testAnnotationProcessor 'io.micronaut:micronaut-inject-java'
- api platform("io.micronaut:micronaut-bom:$micronautVersion") // TODO:
Should this be api?
+ api platform("io.micronaut.platform:micronaut-platform:$micronautVersion")
// TODO: Should this be api?
+ api "com.fasterxml.jackson.core:jackson-databind:$jacksonDatabindVersion"
Review Comment:
Done in 9f4831fa47. Dropped the `:$jacksonDatabindVersion` coordinate. The
micronaut-platform 4.10.10 BOM already imported on the line above pulls
jackson-bom transitively, which manages `jackson-databind`. Resolved version:
`com.fasterxml.jackson.core:jackson-databind -> 2.19.2` (one minor newer than
the previously hard-coded 2.18.3).
Left `jacksonDatabindVersion=2.18.3` in `grails-forge/gradle.properties`
because `grails-forge/buildSrc/build.gradle` still references it on its own
gradle-plugin compile classpath, where no BOM is imported. Happy to tackle that
separately if you want it cleaned up too.
Assisted-by: claude-code:claude-opus-4-7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
