jamesfredley commented on PR #15587:
URL: https://github.com/apache/grails-core/pull/15587#issuecomment-4323218791
@jdaugherty pushed `d695a96152` addressing your review. Quick summary by
area:
## Resolved
| Area | Change |
| --- | --- |
| `README.md` | Re-styled to mongodb's pattern; doc/api links now point at
`grails.apache.org/docs/{latest,snapshot}/grails-data/graphql/manual/` |
| `GormGraphqlGrailsPlugin` | Dropped `author` / `authorEmail` /
`developers`; fixed stale `documentation` URL; matches `MongodbGrailsPlugin`'s
shape |
| `GrailsGraphQLConfiguration` | Now `@Autowired`s
`DataBindingConfigurationProperties`; deleted the duplicated
`DEFAULT_DATE_FORMATS` list |
| `plugin/build.gradle` | Dropped redundant `micronaut-http-client`
(transitively via rxjava2); demoted `micronaut-rxjava2-http-client` to
`compileOnly` so test deps don't leak onto the production classpath; removed
cglib-bridge comment; documented why `bootRun`/`bootTestRun` are disabled;
replaced inline `useJUnitPlatform()` with `gradle/test-config.gradle` include |
| `core/build.gradle` | Same `gradle/test-config.gradle` include for
consistency |
| 4 Grails example apps | Single `plugins {}` block (matches
`spring-boot-app` and `hibernate5/grails-hibernate`); `bootRun {}` blocks
dropped; `project(':grails-data-graphql')` ->
`org.apache.grails:grails-data-graphql` |
| `spring-boot-app/build.gradle` | All four `project(...)` refs (other than
`:grails-bom`) replaced with their published Maven coordinates |
| `PostIntegrationSpec` | Switched from `SimpleDateFormat("...SSSX")` to
`Instant.parse(...)` so the spec accepts both ISO-8601 forms (with or without
millis) |
| `HibernatePersistentGraphQLPropertySpec` | Dropped the speculative comment
about GORM ordering |
17 review threads resolved.
## Left open for direction
- **#15605 BOM tracker** (`gradle.properties` versions, `graphql-java`
version pin in `plugin/build.gradle`) - 3 threads. Will move once the
BOM-restructure backport lands on `7.2.x`.
- **`GraphqlController.browser()` / `GraphqlControllerSpec`** - 2 threads.
The browser action is currently a no-op (returns 404 unless the host app
supplies its own `graphiql.html`). Happy to keep it (current state) or remove
it entirely - waiting on your call.
- **`HibernatePersistentGraphQLPropertySpec` ordering shift** - 1 thread.
Expected values genuinely shifted on Grails 7 GORM but I haven't pinned down
the upstream cause yet. Open to digging deeper or reverting.
## Verified locally
```
./gradlew :grails-data-graphql-core:test :grails-data-graphql:test
./gradlew :grails-data-graphql-core:codeStyle :grails-data-graphql:codeStyle
./gradlew :grails-test-examples-graphql-grails-test-app:test \
:grails-test-examples-graphql-grails-docs-app:test \
:grails-test-examples-graphql-grails-tenant-app:test \
:grails-test-examples-graphql-grails-multi-datastore-app:test \
:grails-test-examples-graphql-spring-boot-app:test
./gradlew :grails-test-examples-graphql-grails-test-app:integrationTest \
:grails-test-examples-graphql-grails-docs-app:integrationTest \
:grails-test-examples-graphql-grails-tenant-app:integrationTest \
:grails-test-examples-graphql-grails-multi-datastore-app:integrationTest
```
All green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
