matrei commented on code in PR #15467:
URL: https://github.com/apache/grails-core/pull/15467#discussion_r3188915792
##########
grails-doc/src/en/guide/commandLine/gradleBuild/gradleDependencies.adoc:
##########
@@ -60,13 +60,33 @@ dependencies {
Note that version numbers are not present in the majority of the dependencies.
-This is thanks to the Spring dependency management plugin which automatically
configures `grails-bom` as a Maven BOM via the Grails Gradle Plugin. This
defines the default dependency versions for most commonly used dependencies and
plugins.
+This is thanks to Gradle's platform support which automatically imports
`grails-bom` as a managed dependency platform via the Grails Gradle Plugin.
This defines the default dependency versions for most commonly used
dependencies and plugins.
Review Comment:
I'm not sure this sentence is 100% accurate. How about: "This is thanks to
the Grails Gradle Plugin, which adds `grails-bom` as a managed dependency
platform. The BOM defines the default versions for most commonly used Grails
dependencies and plugins." Also, I don’t think this should be a separate
paragraph, since it’s a natural continuation of the previous statement.
##########
grails-doc/src/en/guide/commandLine/gradleBuild/gradleDependencies.adoc:
##########
@@ -75,13 +95,35 @@ dependencies {
}
----
-build.gradle, using Spring dependency management plugin:
+==== Using `bom-property-overrides` Standalone (Non-Grails Projects)
+
+The property-override mechanism is published as a standalone, BOM-agnostic
Gradle plugin so it can be reused with any BOM that follows the Maven
`<properties>` convention. Apply it directly when you want the same
`gradle.properties` / `ext['…']` override workflow without applying any Grails
plugin:
+
+[source,groovy]
+----
+plugins {
+ id 'java-library'
+ id 'org.apache.grails.gradle.bom-property-overrides' version
'{GrailsVersion}'
+}
+
+dependencies {
+ implementation platform('com.example:my-bom:1.0.0')
+}
+
+// gradle.properties or build.gradle
Review Comment:
This syntax will not work in `gradle.properties`.
##########
grails-doc/src/en/guide/commandLine/gradleBuild/gradleDependencies.adoc:
##########
@@ -75,13 +95,35 @@ dependencies {
}
----
-build.gradle, using Spring dependency management plugin:
+==== Using `bom-property-overrides` Standalone (Non-Grails Projects)
+
+The property-override mechanism is published as a standalone, BOM-agnostic
Gradle plugin so it can be reused with any BOM that follows the Maven
`<properties>` convention. Apply it directly when you want the same
`gradle.properties` / `ext['…']` override workflow without applying any Grails
plugin:
+
+[source,groovy]
+----
+plugins {
+ id 'java-library'
+ id 'org.apache.grails.gradle.bom-property-overrides' version
'{GrailsVersion}'
+}
+
+dependencies {
+ implementation platform('com.example:my-bom:1.0.0')
+}
+
+// gradle.properties or build.gradle
+ext['slf4j.version'] = '2.0.13'
+----
+
+By default the plugin auto-detects every `platform()` and `enforcedPlatform()`
dependency declared on the project's configurations and registers each one for
property-override processing. You can disable auto-detection or register
additional BOMs explicitly via the `bomPropertyOverrides` extension:
Review Comment:
By default, ... (add comma?)
##########
grails-gradle/bom-property-overrides/build.gradle:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins {
+ id 'groovy'
+ id 'java-gradle-plugin'
+ id 'org.apache.grails.buildsrc.properties'
+ id 'org.apache.grails.buildsrc.dependency-validator'
+ id 'org.apache.grails.buildsrc.compile'
+ id 'org.apache.grails.buildsrc.publish'
+ id 'org.apache.grails.buildsrc.sbom'
+ id 'org.apache.grails.gradle.grails-code-style'
+}
+
+version = projectVersion
+group = 'org.apache.grails'
+
+ext {
+ pomTitle = 'Grails BOM Property Overrides Gradle Plugin'
+ pomDescription = 'A standalone Gradle plugin that enables Maven-style
property-based version overrides for any Gradle platform() BOM. Reads the BOM
POM <properties> block and lets consumers override versions via
gradle.properties or ext[\'property.name\']. Reusable independently of Grails.'
+ pomMavenPublicationName = 'pluginMaven'
+}
+
+dependencies {
+ implementation platform(project(':grails-gradle-bom'))
+
+ // compile with the Groovy version provided by Gradle
Review Comment:
This comment does not seem to be accurate anymore? Isn't the groovy version
taken from the `grails-gradle-bom` here?
##########
grails-gradle/bom-property-overrides/build.gradle:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins {
+ id 'groovy'
+ id 'java-gradle-plugin'
+ id 'org.apache.grails.buildsrc.properties'
+ id 'org.apache.grails.buildsrc.dependency-validator'
+ id 'org.apache.grails.buildsrc.compile'
+ id 'org.apache.grails.buildsrc.publish'
+ id 'org.apache.grails.buildsrc.sbom'
+ id 'org.apache.grails.gradle.grails-code-style'
+}
+
+version = projectVersion
+group = 'org.apache.grails'
+
+ext {
+ pomTitle = 'Grails BOM Property Overrides Gradle Plugin'
+ pomDescription = 'A standalone Gradle plugin that enables Maven-style
property-based version overrides for any Gradle platform() BOM. Reads the BOM
POM <properties> block and lets consumers override versions via
gradle.properties or ext[\'property.name\']. Reusable independently of Grails.'
+ pomMavenPublicationName = 'pluginMaven'
+}
+
+dependencies {
+ implementation platform(project(':grails-gradle-bom'))
+
+ // compile with the Groovy version provided by Gradle
+ // see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
+ compileOnly 'org.apache.groovy:groovy'
+
+ // Testing - Gradle TestKit is auto-added by java-gradle-plugin
+ testImplementation('org.spockframework:spock-core') { transitive = false }
+ testImplementation 'org.apache.groovy:groovy-test-junit5'
+ testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine'
+}
+
+configurations {
+ testCompileClasspath.exclude group: 'org.apache.groovy', module: 'groovy'
Review Comment:
Use parentheses for method calls?
##########
grails-gradle/bom-property-overrides/build.gradle:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins {
+ id 'groovy'
+ id 'java-gradle-plugin'
+ id 'org.apache.grails.buildsrc.properties'
+ id 'org.apache.grails.buildsrc.dependency-validator'
+ id 'org.apache.grails.buildsrc.compile'
+ id 'org.apache.grails.buildsrc.publish'
+ id 'org.apache.grails.buildsrc.sbom'
+ id 'org.apache.grails.gradle.grails-code-style'
+}
+
+version = projectVersion
+group = 'org.apache.grails'
+
+ext {
+ pomTitle = 'Grails BOM Property Overrides Gradle Plugin'
+ pomDescription = 'A standalone Gradle plugin that enables Maven-style
property-based version overrides for any Gradle platform() BOM. Reads the BOM
POM <properties> block and lets consumers override versions via
gradle.properties or ext[\'property.name\']. Reusable independently of Grails.'
+ pomMavenPublicationName = 'pluginMaven'
+}
+
+dependencies {
+ implementation platform(project(':grails-gradle-bom'))
+
+ // compile with the Groovy version provided by Gradle
+ // see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
+ compileOnly 'org.apache.groovy:groovy'
+
+ // Testing - Gradle TestKit is auto-added by java-gradle-plugin
+ testImplementation('org.spockframework:spock-core') { transitive = false }
Review Comment:
Do we still need to exclude transitive dependencies here?
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy:
##########
@@ -360,19 +359,81 @@ ${importStatements}
protected void applyDefaultPlugins(Project project) {
applySpringBootPlugin(project)
Review Comment:
Remove empty line?
##########
grails-gradle/bom-property-overrides/src/main/groovy/org/grails/gradle/plugin/bom/BomPropertyOverridesExtension.groovy:
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.grails.gradle.plugin.bom
+
+import groovy.transform.CompileStatic
+import org.gradle.api.provider.ListProperty
+import org.gradle.api.provider.Property
+
+/**
+ * Configuration for the
+ * {@code org.apache.grails.gradle.bom-property-overrides} plugin.
+ *
+ * <p>Exposed on the project as {@code bomPropertyOverrides}:</p>
+ *
+ * <pre>
+ * apply plugin: 'org.apache.grails.gradle.bom-property-overrides'
+ *
+ * bomPropertyOverrides {
+ * // Disable scanning declared platform() dependencies (default: true)
+ * autoDetect = false
+ *
+ * // Add explicit BOM coordinates - useful when a BOM is referenced
+ * // indirectly (e.g., through a parent plugin) and not declared
+ * // directly via platform() in the consumer's build.gradle
+ * bom 'org.example:my-bom:1.0.0'
+ * bom 'org.example:other-bom:2.0.0'
+ * }
+ *
+ * // Override versions via gradle.properties or ext[]
+ * ext['slf4j.version'] = '2.0.13'
+ * </pre>
+ *
+ * <p>By default ({@code autoDetect = true}) the plugin scans every project
+ * configuration for declared {@code platform()} / {@code enforcedPlatform()}
+ * dependencies and registers each unique BOM for property-override
+ * processing. Explicit entries added via {@link #bom(String)} are always
+ * processed in addition to auto-detected ones, regardless of the
+ * {@code autoDetect} flag.</p>
+ *
+ * @since 8.0
+ */
+@CompileStatic
+class BomPropertyOverridesExtension {
+
+ /**
+ * The name of the project extension exposed on every project.
+ */
+ static final String EXTENSION_NAME = 'bomPropertyOverrides'
+
+ /**
+ * Whether to auto-detect BOMs from declared {@code platform()} /
+ * {@code enforcedPlatform()} dependencies on the project's
+ * configurations. Defaults to {@code true}.
+ */
+ final Property<Boolean> autoDetect
+
+ /**
+ * Explicit list of BOM coordinates ({@code group:artifact:version})
+ * that should be processed for property overrides regardless of
+ * whether they are declared as platforms on the project.
+ */
+ final ListProperty<String> boms
+
+ BomPropertyOverridesExtension(org.gradle.api.model.ObjectFactory objects) {
Review Comment:
Import?
##########
grails-gradle/bom-property-overrides/build.gradle:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins {
+ id 'groovy'
+ id 'java-gradle-plugin'
+ id 'org.apache.grails.buildsrc.properties'
+ id 'org.apache.grails.buildsrc.dependency-validator'
+ id 'org.apache.grails.buildsrc.compile'
+ id 'org.apache.grails.buildsrc.publish'
+ id 'org.apache.grails.buildsrc.sbom'
+ id 'org.apache.grails.gradle.grails-code-style'
+}
+
+version = projectVersion
+group = 'org.apache.grails'
+
+ext {
+ pomTitle = 'Grails BOM Property Overrides Gradle Plugin'
+ pomDescription = 'A standalone Gradle plugin that enables Maven-style
property-based version overrides for any Gradle platform() BOM. Reads the BOM
POM <properties> block and lets consumers override versions via
gradle.properties or ext[\'property.name\']. Reusable independently of Grails.'
+ pomMavenPublicationName = 'pluginMaven'
+}
+
+dependencies {
+ implementation platform(project(':grails-gradle-bom'))
+
+ // compile with the Groovy version provided by Gradle
+ // see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
+ compileOnly 'org.apache.groovy:groovy'
+
+ // Testing - Gradle TestKit is auto-added by java-gradle-plugin
+ testImplementation('org.spockframework:spock-core') { transitive = false }
+ testImplementation 'org.apache.groovy:groovy-test-junit5'
+ testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine'
+}
+
+configurations {
+ testCompileClasspath.exclude group: 'org.apache.groovy', module: 'groovy'
+ testRuntimeClasspath.exclude group: 'org.apache.groovy', module: 'groovy'
+}
+
+gradlePlugin {
+ plugins {
+ bomPropertyOverrides {
+ displayName = 'Grails BOM Property Overrides Plugin'
+ description = 'Enables Maven-style property-based version
overrides for any Gradle platform() BOM. ' +
+ 'Apply this plugin and override versions via
gradle.properties or ext[\'property.name\']. ' +
+ 'Auto-detects declared platform() BOMs by default, or
accepts an explicit list via the ' +
+ 'bomPropertyOverrides extension.'
+ id = 'org.apache.grails.gradle.bom-property-overrides'
+ implementationClass =
'org.grails.gradle.plugin.bom.BomPropertyOverridesPlugin'
+ }
+ }
+}
+
+tasks.withType(Copy) {
Review Comment:
Use `tasks.withType(Copy).configureEach {`?
##########
grails-gradle/bom-property-overrides/src/main/groovy/org/grails/gradle/plugin/bom/BomManagedVersions.groovy:
##########
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.grails.gradle.plugin.bom
+
+import groovy.transform.CompileStatic
+import org.gradle.api.Project
+import org.gradle.api.artifacts.Configuration
+import org.gradle.api.artifacts.DependencyResolveDetails
+import org.gradle.api.logging.Logger
+import org.gradle.api.logging.Logging
+import org.w3c.dom.Document
+import org.w3c.dom.Element
+import org.w3c.dom.NodeList
+
+import javax.xml.parsers.DocumentBuilderFactory
+
+/**
+ * Lightweight replacement for the Spring Dependency Management plugin's
+ * version property override feature.
+ *
+ * <p>Parses BOM POM files to build a mapping of Maven property names
+ * (e.g., {@code slf4j.version}) to the artifacts they control. At
+ * dependency resolution time, checks whether the user has overridden
+ * any of these properties via {@code ext['property.name']} in
+ * {@code build.gradle} or via {@code gradle.properties}, and applies
+ * those overrides using Gradle's {@code
ResolutionStrategy.eachDependency()}.</p>
+ *
+ * <p>Gradle's native {@code platform()} mechanism handles the base
+ * BOM import and default version management. This class only adds the
+ * one feature Gradle lacks: property-based version customization
+ * (see <a href="https://github.com/gradle/gradle/issues/9160";>Gradle
#9160</a>).</p>
+ *
+ * <p>This is the underlying utility used by the
+ * {@code org.apache.grails.gradle.bom-property-overrides} plugin. It is
+ * BOM-agnostic and can be used directly with any BOM that follows the
+ * Maven {@code <properties>} convention for managed versions.</p>
+ *
+ * @since 8.0
+ */
+@CompileStatic
+class BomManagedVersions {
+
+ private static final Logger LOG = Logging.getLogger(BomManagedVersions)
+ private static final int MAX_PROPERTY_INTERPOLATION_DEPTH = 10
+
+ private final Map<String, String> versionOverrides = new LinkedHashMap<>()
+
+ /**
+ * Resolves a BOM, parses its POM chain, and determines which managed
+ * dependency versions need to be overridden based on project properties.
+ *
+ * @param project the Gradle project (used for artifact resolution and
property lookup)
+ * @param bomCoordinates the BOM coordinates in {@code
group:artifact:version} format
+ * @return a BomManagedVersions instance containing any version overrides
to apply
+ */
+ static BomManagedVersions resolve(Project project, String bomCoordinates) {
+ return resolve(project, [bomCoordinates])
+ }
+
+ /**
+ * Resolves multiple BOMs, parses their POM chains, and determines which
+ * managed dependency versions need to be overridden based on project
+ * properties. Useful when a project applies several platforms (e.g., a
+ * Grails BOM plus a Micronaut BOM) and any of them may declare overridable
+ * properties.
+ *
+ * @param project the Gradle project (used for artifact resolution and
property lookup)
+ * @param bomCoordinatesList list of BOM coordinates in {@code
group:artifact:version} format
+ * @return a BomManagedVersions instance containing any version overrides
to apply
+ */
+ static BomManagedVersions resolve(Project project, Collection<String>
bomCoordinatesList) {
+ BomManagedVersions instance = new BomManagedVersions()
+
+ Map<String, String> bomProperties = new LinkedHashMap<>()
Review Comment:
Use `def` for local variables where the type can be inferred? This applies
generally to all added Groovy code (`var` for Java). It makes the code so much
easier to read by letting the variable name be the first-class citizen.
##########
grails-gradle/bom-property-overrides/build.gradle:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins {
+ id 'groovy'
+ id 'java-gradle-plugin'
+ id 'org.apache.grails.buildsrc.properties'
+ id 'org.apache.grails.buildsrc.dependency-validator'
+ id 'org.apache.grails.buildsrc.compile'
+ id 'org.apache.grails.buildsrc.publish'
+ id 'org.apache.grails.buildsrc.sbom'
+ id 'org.apache.grails.gradle.grails-code-style'
+}
+
+version = projectVersion
+group = 'org.apache.grails'
+
+ext {
+ pomTitle = 'Grails BOM Property Overrides Gradle Plugin'
+ pomDescription = 'A standalone Gradle plugin that enables Maven-style
property-based version overrides for any Gradle platform() BOM. Reads the BOM
POM <properties> block and lets consumers override versions via
gradle.properties or ext[\'property.name\']. Reusable independently of Grails.'
Review Comment:
Can we break this line?
##########
grails-gradle/bom-property-overrides/build.gradle:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins {
+ id 'groovy'
+ id 'java-gradle-plugin'
+ id 'org.apache.grails.buildsrc.properties'
+ id 'org.apache.grails.buildsrc.dependency-validator'
+ id 'org.apache.grails.buildsrc.compile'
+ id 'org.apache.grails.buildsrc.publish'
+ id 'org.apache.grails.buildsrc.sbom'
+ id 'org.apache.grails.gradle.grails-code-style'
+}
+
+version = projectVersion
+group = 'org.apache.grails'
+
+ext {
+ pomTitle = 'Grails BOM Property Overrides Gradle Plugin'
+ pomDescription = 'A standalone Gradle plugin that enables Maven-style
property-based version overrides for any Gradle platform() BOM. Reads the BOM
POM <properties> block and lets consumers override versions via
gradle.properties or ext[\'property.name\']. Reusable independently of Grails.'
+ pomMavenPublicationName = 'pluginMaven'
+}
+
+dependencies {
+ implementation platform(project(':grails-gradle-bom'))
+
+ // compile with the Groovy version provided by Gradle
+ // see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
+ compileOnly 'org.apache.groovy:groovy'
+
+ // Testing - Gradle TestKit is auto-added by java-gradle-plugin
+ testImplementation('org.spockframework:spock-core') { transitive = false }
+ testImplementation 'org.apache.groovy:groovy-test-junit5'
+ testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine'
+}
+
+configurations {
+ testCompileClasspath.exclude group: 'org.apache.groovy', module: 'groovy'
+ testRuntimeClasspath.exclude group: 'org.apache.groovy', module: 'groovy'
+}
+
+gradlePlugin {
+ plugins {
+ bomPropertyOverrides {
Review Comment:
Use `register('bomPropertyOverrides') {` for IDE type hints?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
