jamesfredley commented on code in PR #15467:
URL: https://github.com/apache/grails-core/pull/15467#discussion_r3214125917
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy:
##########
@@ -470,6 +524,13 @@ ${importStatements}
return
}
+ // The Grails Gradle Plugin injects a regular platform(grails-bom)
into every
+ // declarable configuration via applyGrailsBom(). For Micronaut
projects the user
+ // must additionally declare an enforcedPlatform(grails-micronaut-bom)
- a different
Review Comment:
Comment was stale - rewrote in 5254097 to call out the
`isExcludedFromBomPlatform` exclusions explicitly:
> The Grails Gradle Plugin injects a regular platform(grails-bom) into each
declarable configuration via applyGrailsBom(), excluding code-quality and
annotation-processor classpaths (see isExcludedFromBomPlatform). For Micronaut
projects ...
##########
grails-test-examples/gsp-spring-boot/app/build.gradle:
##########
@@ -21,7 +21,6 @@ plugins {
id 'java'
id 'war'
id 'org.springframework.boot'
- id 'io.spring.dependency-management'
Review Comment:
The Spring DM removal is the entire point of this PR - it's not specific to
Grails apps. `gsp-spring-boot/app` is one of the example projects this PR
migrates off Spring DM, alongside the standalone Grails apps and the GraphQL
example. Replacing it is the recommended path for plain Spring Boot apps too:
Spring Boot publishes its own Gradle platform now (`spring-boot-dependencies`
is consumable via `dependencies { implementation platform(...) }`), and that's
what this example currently relies on - it imports
`platform(project(':grails-bom'))` on line 39, which transitively imports
`spring-boot-dependencies` via `<scope>import</scope>`. So all the version
constraints Spring DM used to provide are still in effect through the Gradle
platform, just without the second resolution system layered on top.
If the concern is specifically that this Spring-Boot example previously
demonstrated the Spring DM workflow and you'd like a small
`bom-property-overrides` example added to it instead (so the
`gradle.properties` / `ext['…']` override mechanism is still showcased without
Spring DM), I'm happy to add that in this PR or a follow-up - just say the
word. Leaving open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
