jdaugherty commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3341617260
##########
grails-test-examples/plugins/micronaut-singleton/build.gradle:
##########
@@ -25,6 +25,10 @@ plugins {
version = '0.1-SNAPSHOT'
group = 'com.example.grails.plugins'
+// The Micronaut platform ships org.ow2.asm above what the
grails-micronaut-bom pins; allow the
Review Comment:
the whole point of the dependency validation is to ensure we match a version
higher in the bom or exclude it from the bom so our version takes precedence.
This should be removed.
##########
grails-test-examples/views-functional-tests/grails-app/controllers/functional/tests/ProductController.groovy:
##########
@@ -34,9 +34,8 @@ class ProductController extends RestfulController<Product> {
* @param max The maximum
* @return A list of resources
*/
- @Override
- def index(Integer max) {
- params.max = Math.min(max ?: 10, 100)
+ def index() {
Review Comment:
Why are you changing binding syntax in this file? It seems out of scope of
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
