jdaugherty commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3341646710
##########
grails-views-gson/src/test/groovy/grails/plugin/json/view/JsonViewTemplateResolverSpec.groovy:
##########
@@ -64,6 +71,8 @@ class JsonViewTemplateResolverSpec extends Specification {
}
+ // Skip on Groovy 5+ - mocking final methods
(GrailsWebRequest.getRequest()) not supported without special configuration
+ @IgnoreIf({ instance.isGroovy5OrLater() })
Review Comment:
We should not be ignoring something to get this passing, we need to add the
appropriate library.
##########
grails-views-core/src/main/groovy/grails/views/mvc/renderer/DefaultViewRenderer.groovy:
##########
@@ -118,7 +118,7 @@ abstract class DefaultViewRenderer<T> extends
DefaultHtmlRenderer<T> {
}
if (view != null) {
- Map<String, ?> model
+ Map<String, Object> model
Review Comment:
Why isn't ? allowed for Object? @paulk-asert is this an intentional
generics change in Groovy?
##########
grails-validation/src/main/groovy/grails/validation/Validateable.groovy:
##########
@@ -279,4 +280,27 @@ trait Validateable {
static boolean defaultNullable() {
false
}
+
+ /**
+ * Resolves defaultNullable() via reflection to preserve trait
static-method override semantics (Groovy 5).
+ * Reproducer:
https://github.com/jamesfredley/groovy-trait-static-method-override-bug
Review Comment:
Can we refer to the groovy ticket here since it has history that's relevant
to this implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
