jamesfredley commented on PR #15568: URL: https://github.com/apache/grails-core/pull/15568#issuecomment-4745093792
Pushed a focused CI-fix commit: `534fa21410` (`Fix Hibernate 7 CI regressions`). What changed: - `HibernateQuerySpec.isNotNull` now uses the nullable `face` association instead of creating an invalid `Person` fixture without `lastName`. - Restored `grails.gorm.default.nullable: false` in the Hibernate 7 views functional-test app so it matches the canonical app clone's constraints. Targeted verification run locally with `--rerun-tasks`: - `./gradlew :grails-data-hibernate7-core:test --tests "grails.gorm.tests.hibernatequery.HibernateQuerySpec.isNotNull" --rerun-tasks` - passed. - `./gradlew :grails-test-examples-hibernate7-views-functional-tests:integrationTest --tests "functional.tests.BookSpec" --rerun-tasks` - passed. - `./gradlew aggregateViolations --continue` - passed earlier; violation reports showed no issues. Thread status: - Resolved the `ConnectionSource.DEFAULT` thread after leaving the existing lowercase `default` behavior intact. - I did not resolve the `GroovyPagesServlet` classloader thread because this commit does not address it. - I also did not mark Matthias's broader Hibernate 5 / review-scope comments as resolved. They remain open for the larger review pass rather than being hidden by this targeted CI fix. CI has restarted on the pushed commit and is currently in progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
