jamesfredley commented on PR #15568: URL: https://github.com/apache/grails-core/pull/15568#issuecomment-4745646113
Pushed a review-cleanup follow-up on top of the CI fix. New head is `c72941622842ed8368913db2f88faa5c1b9339b6`. New commits: - `107a1f510c` Remove obsolete Hibernate 7 triage report - `cb022001b9` Clean Hibernate 5 binder review leftovers - `11ae39ddc8` Clean Hibernate 7 source review leftovers - `b2ad2d8500` Clean Hibernate 7 test review leftovers - `c729416228` Update Hibernate 7 review guidance docs Verification run locally: - `./gradlew :grails-data-hibernate5-core:compileGroovy --rerun-tasks` - passed. - `./gradlew :grails-data-hibernate7-core:test --tests "grails.gorm.hibernate.mapping.HibernateMappingBuilderSpec" --rerun-tasks` - passed, 79 tests. - `./gradlew :grails-data-hibernate7:test --tests "grails.orm.bootstrap.HibernateDatastoreSpringInitializerSpec" --rerun-tasks` - passed, 1 test. - `./gradlew :grails-doc:publishGuide -x aggregateGroovydoc` - passed. - `./gradlew aggregateViolations --rerun-tasks --continue` - passed; Checkstyle, CodeNarc, PMD, and SpotBugs summaries report no violations. I also tried the full required root gate `./gradlew clean aggregateViolations :grails-test-report:check --continue`; it did not finish inside the 10-minute local shell cap and surfaced an unrelated `grails-datamapping-core-test` `DirtyCheckingAfterListenerSpec` `@PendingFeatureIf` passing-unexpectedly failure before timing out. I am not marking unrelated review threads resolved from that. Resolved only the threads covered by these commits, including the H5 `getFirst`/fully-qualified-list comments, Checker Framework annotation removal, stale comments/println/indentation, README typo/report deletion, explicit Spring ORM module names, cascade whitespace, and the stale Hibernate 7 skill guidance. Broader behavior/design threads remain open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
