borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3439422340
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/NotNullQuerySpec.groovy:
##########
@@ -24,9 +24,10 @@ import
org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
class NotNullQuerySpec extends GrailsDataTckSpec<GrailsDataCoreTckManager> {
void setupSpec() {
- manager.domainClasses.addAll([NullMe, NullOther])
+ manager.addAllDomainClasses([NullMe, NullOther])
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/NotNullQuerySpec.groovy:
##########
@@ -67,6 +68,7 @@ class NotNullQuerySpec extends
GrailsDataTckSpec<GrailsDataCoreTckManager> {
results[0].name == "Bob"
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/RangeQuerySpec.groovy:
##########
@@ -18,20 +18,24 @@
*/
package org.apache.grails.data.testing.tck.tests
-import groovy.time.TimeCategory
-
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
import org.apache.grails.data.testing.tck.domains.ChildEntity
import org.apache.grails.data.testing.tck.domains.Person
import org.apache.grails.data.testing.tck.domains.Publication
import org.apache.grails.data.testing.tck.domains.TestEntity
+import groovy.time.TimeCategory
+import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
/**
* Abstract base test for querying ranges. Subclasses should do the necessary
setup to configure GORM
*/
class RangeQuerySpec extends GrailsDataTckSpec {
- void 'Test between query with dates'() {
+ void setupSpec() {
+ manager.addAllDomainClasses([Publication, TestEntity, Person,
ChildEntity])
+ }
+
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/RangeQuerySpec.groovy:
##########
@@ -50,7 +54,8 @@ class RangeQuerySpec extends GrailsDataTckSpec {
results.size() == 2
}
- void 'Test between query'() {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/RangeQuerySpec.groovy:
##########
@@ -78,7 +83,8 @@ class RangeQuerySpec extends GrailsDataTckSpec {
4 == results.size()
}
- void 'Test greater than or equal to and less than or equal to queries'() {
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/PagedResultSpec.groovy:
##########
@@ -18,12 +18,17 @@
*/
package org.apache.grails.data.testing.tck.tests
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
import org.apache.grails.data.testing.tck.domains.Person
+import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
[email protected]({ System.getProperty('hibernate5.gorm.suite') == 'true'
|| System.getProperty('mongodb.gorm.suite') == 'true' ||
System.getProperty('core.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/PersistenceEventListenerSpec.groovy:
##########
@@ -83,6 +83,7 @@ class PersistenceEventListenerSpec extends GrailsDataTckSpec {
listener.events[-2] instanceof PreDeleteEvent
}
+ @spock.lang.Requires({ System.getProperty('hibernate5.gorm.suite') ==
'true' || System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
These `@Requires` annotations were reverted in a prior cleanup commit — the
affected specs run without restrictions in the current branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
