borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3439413382


##########
grails-data-hibernate5/core/src/test/groovy/org/grails/orm/hibernate/connections/SingleTenantSpec.groovy:
##########
@@ -59,7 +62,12 @@ class SingleTenantSpec extends Specification {
                 
'dataSources.moreBooks':[url:"jdbc:h2:mem:moreBooks;LOCK_TIMEOUT=10000"]
         ]
 
-        HibernateDatastore datastore = new 
HibernateDatastore(DatastoreUtils.createPropertyResolver(config),Book, 
SingleTenantAuthor )
+        datastore = new 
HibernateDatastore(DatastoreUtils.createPropertyResolver(config),Book, 
SingleTenantAuthor )
+    }
+
+    void "Test a database per tenant multi tenancy"() {
+        given:"A configuration for multiple data sources"
+        System.setProperty(SystemPropertyTenantResolver.PROPERTY_NAME, "")

Review Comment:
   This file (`SingleTenantSpec.groovy`) has no changes in the current branch — 
the comment references an earlier intermediate commit.



##########
grails-test-examples/hibernate7/grails-schema-per-tenant/src/test/groovy/schemapertenant/SchemaPerTenantSpec.groovy:
##########
@@ -50,6 +51,9 @@ class SchemaPerTenantSpec extends HibernateSpec implements 
GrailsUnitTest {
         hibernateDatastore.addTenantForSchema("moreBooks")
         hibernateDatastore.addTenantForSchema("evenMoreBooks")
     }
+    def cleanup() {

Review Comment:
   These files (`grails-test-examples/hibernate7`) have no changes in the 
current branch — the comment references an earlier commit.



##########
grails-test-examples/hibernate7/grails-partitioned-multi-tenancy/src/test/groovy/example/PartitionedMultiTenancySpec.groovy:
##########
@@ -40,6 +41,10 @@ class PartitionedMultiTenancySpec extends HibernateSpec {
         )
     }
 
+    def cleanup() {
+        System.setProperty(SystemPropertyTenantResolver.PROPERTY_NAME, "")

Review Comment:
   This file has no changes in the current branch — the comment references an 
earlier commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to