borinquenkid commented on PR #15568: URL: https://github.com/apache/grails-core/pull/15568#issuecomment-4748722675
## Review Comment Status — All Threads Addressed All outstanding review threads have now been replied to. Here's the current state: ### ✅ Addressed / Resolved - **Reverted items**: ~10 threads on , , , , , , , , , and `build.gradle` — all files are unchanged from `8.0.x` in the current revision. - **SaveWithInvalidEntitySpec**: NPE bug fixed, `@Ignore` removed, `ConstraintViolationException` added to expected exception types, `@Issue` updated with `#14616`. - **IdentityEnumTypeSpec**: `@Enumerated(EnumType.STRING)` added — required by H7's stricter type resolution for custom `UserType` implementations. - **CompositeIdWithJoinTableSpec**: `@Rollback` removed (TCK lifecycle handles cleanup), `Comparable` added for `SortedSet` ordering requirement. - **CompositeIdWithManyToOneAndSequenceSpec**: Migrated to `HibernateGormDatastoreSpec`, relationship direction corrected to one-to-many. - **WhereQueryOldIssueVerificationSpec**: `belongsTo = [WqBiAuthor]` list form — eliminates ambiguous bare-class mapping warning. - **DetachedCriteria**: Projection guard moved to `AbstractHibernateQuery.countResults()` in the H5/H7 adapter layer. - **H7 cache factory class**: `SingletonEhCacheRegionFactory` → `JCacheRegionFactory` (committed in `26b012fe5a`). - **HibernateGormEnhancerSpec**: Unused `GormEnhancer` import removed. - **HibernateGormDatastoreSpec**: Javadoc updated to describe the class rather than compare with old impl. - **PersistentPropertySpec**: Correct — H5 has its own `grails.gorm.tests.HibernateGormDatastoreSpec` backed by `GrailsDataHibernate5TckManager`. - **SoftKeySpec**: `Integer.valueOf()` used in current revision (deprecated `new Integer()` was already fixed). - **HibernateProxyHandler5Spec**: Correctly extends `Specification` directly — pure unit test, no datastore needed. - **Hibernate5OptimisticLockingSpec**: Exception assertion relaxed to `OptimisticLockingFailureException` parent class for resilience across provider versions. - **RLikeSpec (TCK)**: `@IgnoreIf` removed — TCK spec runs on any datastore that opts in, no annotation barriers. - **PagedResultSpecHibernate**: H7-specific — tests the derived-table subquery count path in `AbstractHibernateQuery.countResults()`. ### ⏳ Awaiting Reviewer Input - **CriteriaMethods extensibility** (3221897097) — extensibility via subclassing vs. Groovy extension modules; needs explicit sign-off before merge. - **GroovyProxyFactory `getProxiedClass()`** (3222936394) — awaiting Scott's PR #15650 resolution on regression concerns. - **GroovyPagesServlet `Thread.currentThread().getContextClassLoader()`** (3222798990) — awaiting @davydotcom's input on whether the explicit TCCL lookup is acceptable. - **GrailsHibernateTemplate H5→H7 delta** (3221926309) — will open a follow-up issue to formally document the delta. - **MongoDB docs `build.gradle`** (3223008064) — deferred to @jamesfredley. - **grails-test-examples JCache TODO** (3222765476) — explicit provider configuration will be added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
