borinquenkid commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3440339483
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/UpdateWithProxyPresentSpec.groovy:
##########
@@ -28,10 +30,11 @@ import org.apache.grails.data.testing.tck.domains.PetType
/**
* @author graemerocher
*/
+@IgnoreIf({ System.getProperty('hibernate7.gorm.suite') == 'true' })
Review Comment:
Reverted — this file is unchanged from `8.0.x` in the current revision.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/OptimisticLockingSpec.groovy:
##########
@@ -19,24 +19,31 @@
package org.apache.grails.data.testing.tck.tests
import spock.lang.IgnoreIf
+import spock.lang.Requires
import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
import org.apache.grails.data.testing.tck.domains.OptLockNotVersioned
import org.apache.grails.data.testing.tck.domains.OptLockVersioned
+import org.springframework.dao.OptimisticLockingFailureException
+
import org.grails.datastore.mapping.core.OptimisticLockingException
/**
* @author Burt Beckwith
*/
+@Requires({ System.getProperty('hibernate5.gorm.suite') == 'true' ||
System.getProperty('hibernate7.gorm.suite') == 'true' ||
System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
Reverted — this file is unchanged from `8.0.x` in the current revision.
##########
grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/OptimisticLockingSpec.groovy:
##########
@@ -59,67 +66,132 @@ class OptimisticLockingSpec extends GrailsDataTckSpec {
o.version == 1
}
- // hibernate has a customized version of this
- @IgnoreIf({ System.getProperty('hibernate5.gorm.suite') })
+ @IgnoreIf({ System.getProperty('mongodb.gorm.suite') == 'true' })
Review Comment:
Reverted — this file is unchanged from `8.0.x` in the current revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
