The GitHub Actions job "Code Style" on 
grails-core.git/feature/plugin-before-autoconfig-phase has failed.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
931c0426cd4cbcd1aeaab12f08611117b064f05f / Scott Murphy Heiberg 
<[email protected]>
Tier 1: make Controllers Grails-specific beans overridable 
(@ConditionalOnMissingBean)

grailsWebRequestFilter (the FilterRegistrationBean) and webMvcConfig 
(GrailsWebMvcConfigurer) are
Grails-specific, so @ConditionalOnMissingBean is zero-risk (both "matched" in 
app1's conditions
report — created by default, now overridable).

Deliberately NOT migrated: dispatcherServlet / dispatcherServletRegistration 
(GrailsDispatcherServlet
intentionally REPLACES Boot's; ControllersAutoConfiguration is only 
@AutoConfigureBefore
WebMvcAutoConfiguration, not DispatcherServletAutoConfiguration, so making it 
conditional risks
deferring to Boot's plain DispatcherServlet) and multipartConfigElement (Boot's 
MultipartAutoConfiguration
provides a @ConditionalOnMissingBean one; same ordering risk would lose Grails' 
config-driven settings).
Those are the "intentional override of a Boot bean" category that legitimately 
stays.

Report URL: https://github.com/apache/grails-core/actions/runs/27999675716

With regards,
GitHub Actions via GitBox

Reply via email to