The GitHub Actions job "Code Style" on grails-core.git/feature/plugin-before-autoconfig-phase has failed. Run started by GitHub user codeconsole (triggered by codeconsole).
Head commit for run: ad122ae9cbf16fc121658dda730e3cce47b7aab9 / Scott Murphy Heiberg <[email protected]> Address second review: complete listener-leak fix, drop dead profile filter, search=CURRENT - C1 (complete the earlier listener-leak fix): the throwaway DefaultGrailsApplication was still registering as an ApplicationListener on the real context via setApplicationContext. The drain only needs the app's config, so the early phase now gives it NO context at all (drops setApplicationContext + setMainContext); plugins were already not given the context. Impact was benign (the app listener only sets an inert flag on a GC'd object), but it's the same bug class the earlier review fixed for plugins, now closed on the GrailsApplication path too. - C3 (remove dead code): doRuntimeConfigurationBeforeAutoConfiguration's profile filter was inert — DefaultGrailsPlugin.profiles is never populated (isEnabled() always true), and the runtime profile isn't active this early anyway. Dropped the activeProfiles read entirely; the live supportsCurrentScopeAndEnvironment check + per-plugin error isolation remain. - C4: add search = SearchStrategy.CURRENT to the i18n localeResolver/messageSource/localeChangeInterceptor @ConditionalOnMissingBean guards, matching Boot's own messageSource, so they don't defer to an ancestor context's same-named bean in a parent/child setup. Validated: grails-core compiles + full :grails-core:test green; app3 deferral integration test passes (real drain unaffected by dropping the app context); app1 boots clean. Report URL: https://github.com/apache/grails-core/actions/runs/28000925167 With regards, GitHub Actions via GitBox
