borinquenkid commented on code in PR #15568: URL: https://github.com/apache/grails-core/pull/15568#discussion_r3463099829
########## grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/proxy/GrailsBytecodeProvider.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.grails.orm.hibernate.proxy; + +import java.util.Map; + +import org.hibernate.bytecode.enhance.spi.EnhancementContext; +import org.hibernate.bytecode.enhance.spi.Enhancer; +import org.hibernate.bytecode.spi.BytecodeProvider; +import org.hibernate.bytecode.spi.ProxyFactoryFactory; +import org.hibernate.bytecode.spi.ReflectionOptimizer; +import org.hibernate.property.access.spi.PropertyAccess; +import org.hibernate.proxy.pojo.bytebuddy.ByteBuddyProxyHelper; + +/** + * A {@link BytecodeProvider} implementation for Hibernate 7 that provides Groovy-aware proxies. + * + * @author Graeme Rocher + * @since 7.0 + */ Review Comment: You were right to question the provenance. Checked the history: this class is new in this PR (not on 8.0.x) and was authored by me, not Graeme — the `@author` tag was simply incorrect. Corrected the author and fixed `@since 7.0` to `@since 8.0` to match the branch (commit e6788e0fd6). Resolving. ########## grails-data-hibernate7/grails-plugin/src/main/groovy/grails/plugin/hibernate/HibernateGrailsPlugin.groovy: ########## Review Comment: Good catch — updated `grailsVersion` to `8.0.0-SNAPSHOT > *` in both the H5 and H7 plugins so they match the branch and stay consistent with each other (commit d082770ecc). Resolving. ########## grails-data-hibernate7/core/src/main/groovy/grails/gorm/hibernate/HibernateEntity.groovy: ########## Review Comment: To clarify the final state (and apologies for the conflicting replies earlier in the thread): `HibernateEntity` in `grails-data-hibernate7` is a new class — not on 8.0.x, and it does not modify any existing API. The change is purely additive: `findAllWithNativeSql`/`findWithNativeSql` are the primary names, and `findAllWithSql`/`findWithSql` are retained as `@Deprecated` aliases that still work. So nothing is renamed or removed, H5 is untouched, and existing `findAllWithSql` usage continues to compile and run against H7. The explicit naming reflects that these execute native SQL (bypassing the HQL parser), distinct from `findAll` (HQL). Since no existing public API is changed or removed, there is nothing here that needs separate consensus. Resolving — happy to revisit if you disagree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
