jamesfredley commented on PR #15694:
URL: https://github.com/apache/grails-core/pull/15694#issuecomment-4794421889
Updated for the latest review feedback:
- Removed the generated `tasks.matching { it.name == 'bootRun' }` block from
Forge's `build.gradle` template.
- Moved `spring.output.ansi.console-available=true` into
`GrailsGradlePlugin` using the existing lazy
`project.tasks.withType(BootRun).configureEach` configuration path.
- Updated `LogbackSpec` to assert generated apps no longer inline the
`bootRun` ANSI config.
- Added a Grails Gradle plugin TestKit fixture/spec assertion that `BootRun`
receives the Spring Boot console availability system property from the plugin.
Verified with:
- `./gradlew :grails-gradle-plugins:test --tests
org.grails.gradle.plugin.core.GrailsGradlePluginToolchainSpec`
- `./gradlew :grails-forge-core:test --tests
org.grails.forge.feature.logging.LogbackSpec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
