jdaugherty commented on code in PR #15694:
URL: https://github.com/apache/grails-core/pull/15694#discussion_r3498509665
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy:
##########
@@ -846,6 +846,7 @@ class GrailsGradlePlugin extends GroovyPlugin {
project.tasks.withType(BootRun).configureEach { BootRun it ->
it.dependsOn(findMainClassTask)
it.mainClass.convention(GrailsGradlePlugin.getMainClassProvider(project))
+ it.systemProperty('spring.output.ansi.console-available',
'true')
Review Comment:
Shouldn't this be where OS != Windows?
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/logging/template/logback.rocker.raw:
##########
@@ -17,14 +17,14 @@ specific language governing permissions and limitations
under the License.
*@
-@args (String projectName, String packageName, boolean jansi)
+@args (String projectName, String packageName)
<?xml version="1.0" encoding="UTF-8"?>
<configuration>
<include resource="org/springframework/boot/logging/logback/defaults.xml"/>
<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
- <withJansi>@jansi</withJansi>
+ <withJansi>false</withJansi>
Review Comment:
Should we add a comment that this is incompatible with some reloading tools?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
