jamesfredley commented on PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#issuecomment-4805671675
Merged the latest `8.0.x` changes into `grails8-groovy5-sb4` and pushed the
branch.
What changed in this update:
- Resolved the merge conflicts in the GSP Spring Boot and Spring
dependency-management test examples by keeping the new Grails BOM
`platform(project(':grails-bom'))` setup from `8.0.x`.
- Brought in the `run-app` / `stop-app` PID-file support and related
tests/docs from `8.0.x`.
- Confirmed the previous missing SiteMesh artifact path now resolves
`org.sitemesh:spring-webmvc-sitemesh` to `3.3.0-M1`.
- Re-ran the previously failing SiteMesh 2 scaffolding `User list`
integration spec with CI-style flags and it passed.
Local verification run:
- `git diff --check`
- `:grails-test-examples-scaffolding:integrationTest --tests
"com.example.UserControllerSpec.User list" -PgebAtCheckWaiting
-PgrailsIndy=false`
- `:grails-test-examples-gsp-spring-boot:dependencyInsight --dependency
org.sitemesh:spring-webmvc-sitemesh --configuration runtimeClasspath
--refresh-dependencies`
- `:grails-test-examples-gsp-spring-boot:bootWar --refresh-dependencies`
- `:grails-test-examples-spring-dependency-management:bootJar
--refresh-dependencies`
- Focused tests for `GrailsAppPidFileSpec`,
`DefaultGrailsPluginManagerSpec`, `BootRunExitCodeVerifierSpec`,
`GrailsGradlePluginToolchainSpec`, and `RunningApplicationProcessSpec`
Review gate: GREEN from Oracle session `ses_0fe86dcfbffejVkLi5FDHkDmSl`.
Note: the full required aggregate command `./gradlew clean
aggregateViolations :grails-test-report:check --continue` was started, produced
no generated Checkstyle/CodeNarc/PMD/SpotBugs violations in the reports
inspected, but exceeded the local 10-minute tool timeout before completion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
