jamesfredley commented on code in PR #15801:
URL: https://github.com/apache/grails-core/pull/15801#discussion_r3510080544


##########
grails-controllers/src/main/groovy/grails/artefact/controller/support/ResponseRenderer.groovy:
##########
@@ -134,7 +134,7 @@ trait ResponseRenderer extends WebAttributes {
         GrailsWebRequest webRequest = (GrailsWebRequest) 
RequestContextHolder.currentRequestAttributes()
         HttpServletResponse response = webRequest.currentResponse
         webRequest.renderView = false
-        applyContentType(response, null, object)
+        applyContentType(response, null, object, true, 'text/plain')

Review Comment:
   I looked at narrowing the PR to only the filename/disposition fixes and 
leaving inspect-style render output on the existing default, but review-gate 
flagged that as reintroducing the exact browser-interpreted inspect-output risk 
this branch is trying to avoid. The current implementation still renders the 
same inspect string; it only changes the default response media type for the 
inspect fallback from browser-interpreted HTML to text/plain unless the caller 
explicitly sets a content type. I am leaving this thread unresolved for 
maintainer discussion rather than treating it as resolved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to