borinquenkid commented on PR #15934: URL: https://github.com/apache/grails-core/pull/15934#issuecomment-4929860592
**Note:** This comment was generated by an AI coding assistant (Claude), directed by a human reviewer, as a follow-up to the coverage audit above. All 5 gaps from the audit are addressed as of e737052, and confirmed locally: 1. **Mongo OSIV** — `OpenSessionInViewSpec` (mongodb/base) added. 2. **`/actuator/health`** — assertion added to `ActuatorEnvClosureSpec`, passes locally. 3. **`BeanDefinitionOverrideException` edge** — new test in `EarlyPluginRegistrationOrderingSpec`, passes locally. 4. **"Built exactly once"** — reworded to assert a single manager pass (not a throwaway-then-real double pass); the original wording was corrected in the upgrade notes since a plugin is legitimately instantiated twice (reference `GrailsClass` + real instance, pre-existing behavior). Passes locally. 5. **Flag-reset-on-exception** — new test with a throwing `doWithSpring`, asserts `Environment.isInitializing()` resets. Passes locally. On top of that, `d054328fe1` adds a second, unit-testable version of the Mongo OSIV coverage in `grails-data-mongodb/core` (`MongoOpenSessionInViewSpec`), alongside the existing `mongodb/base` functional spec. The functional spec depends on an external Mongo already listening on `localhost:27017` and can't be verified without that; this one uses the `AutoStartedMongoSpec` base already in this module (Testcontainers' `MongoDBContainer`), so it only needs Docker. It exercises `MongoDbDataStoreSpringInitializer` against a real `GenericWebApplicationContext` with no `dispatcherServlet` bean definition present — the exact registration-order-independent scenario `isWebApplicationRegistry()` was introduced for — plus a non-web control case. Both new tests pass locally, and the full `grails-data-mongodb-core` suite and `codeStyle` are clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
