borinquenkid commented on code in PR #15972:
URL: https://github.com/apache/grails-core/pull/15972#discussion_r3564884078
##########
grails-data-neo4j/examples/test-data-service/build.gradle:
##########
@@ -1,37 +0,0 @@
-/*
Review Comment:
Follow-up: both restored, on the `grails-test-examples/neo4j/` layout like
the other three.
**`neo4j-standalone`** (0ca480de0d) — the version dropped from
`grails-data-neo4j/examples/` was actually already in good shape; re-authored
against the monorepo's convention plugins, modeled on
`grails-test-examples/hibernate5/standalone-hibernate` (the established "no
Grails app" precedent) plus the Jetty-downgrade/`--add-opens` args the other
Neo4j apps need. Verified: `PersonServiceSpec` passes, exercising
`GormServices`/`@Cypher` against a raw `Neo4jDatastore` - coverage the other
three (Spring-wired) apps don't provide.
**`test-data-service`** (3afc76ae58) — the dropped version was genuinely
stale rather than just unmoved: `gradle.properties` pinned
`grailsVersion=6.0.0-RC1`, and `build.gradle` had copy-paste
`project(":mongodb-gson-templates")`/`project(":grails-plugin")` references
never adapted for Neo4j. Domain classes/services/specs turned out byte-for-byte
identical to `grails-test-examples/mongodb/test-data-service` (the current,
working sibling for this exact archetype), so cloned that instead of trying to
resurrect the stale copy, and swapped only the genuinely datastore-specific
pieces (dependency coordinate + Jetty/add-opens, the `application.yml`
connection block, and `Application.groovy`'s bootstrap - mongodb's version
starts a Testcontainers container, which doesn't apply to Neo4j's embedded
harness). Verified: `TestServiceSpec` (4/4) and `StudentServiceSpec` (1/1)
pass, 0 failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
