borinquenkid commented on code in PR #15972:
URL: https://github.com/apache/grails-core/pull/15972#discussion_r3564933878
##########
settings.gradle:
##########
@@ -397,6 +414,16 @@
project(':grails-test-examples-mongodb-test-data-service').projectDir = new File
include 'grails-test-examples-mongodb-gson-templates'
project(':grails-test-examples-mongodb-gson-templates').projectDir = new
File(settingsDir, 'grails-test-examples/mongodb/gson-templates')
+// functional tests - neo4j examples
+include 'grails-test-examples-neo4j-grails3-neo4j'
+project(':grails-test-examples-neo4j-grails3-neo4j').projectDir = new
File(settingsDir, 'grails-test-examples/neo4j/grails3-neo4j')
Review Comment:
Naming convention item is now fully done, in two commits:
1. `grails-datastore-gorm-neo4j` → `grails-data-neo4j-core` (0163e87554),
matching `grails-data-mongodb-core`/`grails-data-hibernate5-core`. 145 files
moved as clean renames; updated every reference across settings.gradle,
publish-root-config.gradle, grails-plugin/boot-plugin/docs build.gradle files,
all example apps, RENAME.md, and rename_gradle_artifacts.sh. Also simplified
`grails-data-tck-config.gradle`'s Neo4j project-matching back to a plain
`startsWith('grails-data-neo4j')` - the `contains('neo4j')` workaround from
earlier in this PR existed specifically because of the inconsistency this
commit fixes.
2. `grails3-neo4j`/`grails3-neo4j-hibernate` → `base`/`hibernate5`
(7eedcb91cc), matching `grails-test-examples/mongodb/base`/`hibernate5`.
Package declarations unaffected (both already used the datastore-agnostic
`functional.tests` package).
All five modules and all five example apps compile cleanly against the
renamed layout. Combined with `gorm-neo4j-spring-boot` →
`grails-data-neo4j-spring-boot` from earlier (d580d61465), every Neo4j module
and example app now follows the same naming convention as the other datastores
- nothing left inconsistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
