codeconsole opened a new pull request, #15974: URL: https://github.com/apache/grails-core/pull/15974
The application generated by grails-forge ships a language selector in its navbar, but `index.gsp` was hardcoded English — switching languages changed nothing on the page. ### Changes - **`gsp/index.gsp` template**: every user-facing string now renders through `<g:message>` (headings, card titles, table headers, `aria-label`s). Product names (Grails, Spring Boot, Groovy, JVM) stay literal. - **All 18 bundled locales** (`i18n/messages*.properties` + English defaults): 31 new `welcome.*` keys per bundle, translated for cs, da, de, es, fr, it, ja, nb, nl, pl, pt_BR, pt_PT, ru, sk, sv, th and zh_CN. The controller count renders through a `MessageFormat` choice, or a genitive phrasing where a language's plural rules can't be expressed as a choice (cs, pl, ru, sk). ### Tests - `GrailsGspSpec."test default index page is internationalized"` — the generated page uses message codes and no hardcoded user-facing English remains. - `GrailsDefaultPluginsSpec."test every i18n bundle translates the welcome page"` — every locale bundle carries the welcome keys, with byte-intact spot checks of the Russian/Japanese/Thai/Chinese titles surviving the template pipeline. - Full `:grails-forge-core:test` run green. All 18 locales were also verified end-to-end in a generated running application (response `charset=UTF-8`, strict UTF-8 byte validation, translated content matching the bundles). ### Note Correct rendering of non-Latin-1 locales also depends on the SiteMesh `3.3.0-M3` upgrade (companion PR to follow once M3 syncs to Maven Central), which fixes the response charset in the view-resolver integration. Without it, decorated pages fall back to the container's locale-derived charset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
